-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fixed: Correct spelling and add codespell configuration #16767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add PHPCS and correct app/Importer/ for PSR-12 (errors only)
|
Is there a particular advantage to codespell over other PHP-based code quality tooling? |
|
I’m not sure why you’re taking your toys and going home. I simply asked for some discussions and consideration for the maintainers and the project. A lot of your changes are good, and we’ve been happy to take them, but adding features that haven’t been discussed previously does put a burden on us. We can’t take every feature, and not every feature makes sense (for example, geolocating on location, when the most common use case is one where a location gets created when the user isn’t physically there.) I don’t know why you’re taking this so personally. I’ve accepted most of your PRs, I just prefer a discussion to happen around new features, which I don’t think is unreasonable. If you’d like to discuss this further, you can reach me at [email protected]. Your work is good, and we’ve appreciated it, we just need a little more conversation so we can share with you the direction we’re going, the things we’re working on, and so on. |
https://github.com/codespell-project/codespell is a useful linter. While this is a widespread change, I did hand apply these. If wanted, can break this up into smaller chunks.
To using the tooling; assuming you have python - add via
pip install codespelland run ascodespellOptional extras: